Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard to ensure CAPISTRANO::VERSION is defined #984

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

waltjones
Copy link
Contributor

Fixes: #975

Capistrano 2.x doesn't have a VERSION constant. (Instead it has a Version property.) This PR ensures the constant is present before testing its value. If the constant isn't present, no further check is needed since the code path only cares about >= 3.0.

There's also some light refactoring for line length and rubocop.

Copy link

@ajtran ajtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid!

@waltjones waltjones merged commit 2e6980d into master Jul 21, 2020
@waltjones waltjones deleted the wj-capistrano-version-guard branch June 27, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollbar 2.19+ Incompatible with earlier Capistrano version
2 participants