Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

captureIp has no effect for Electron apps #963

Closed
shadow-light opened this issue Aug 10, 2021 · 1 comment · Fixed by #1008
Closed

captureIp has no effect for Electron apps #963

shadow-light opened this issue Aug 10, 2021 · 1 comment · Fixed by #1008

Comments

@shadow-light
Copy link

The captureIp config param appears to be ignored when there is no window, i.e. Node. Which makes sense when you are capturing errors on a node server. But it also stops capturing IP for Electron apps, where it can be useful to be able to know how many users are affected by an issue.

A workaround is to manually set payload.request.user_ip to $remote_ip or $remote_ip_anonymize.
@waltjones waltjones self-assigned this Mar 17, 2022
@waltjones waltjones mentioned this issue Mar 21, 2022
Merged
7 tasks
@waltjones waltjones removed their assignment Apr 26, 2022
@waltjones
Copy link
Contributor

Released in v2.25.2, https://github.com/rollbar/rollbar.js/releases/tag/v2.25.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow captureIp without a window object rollbar/rollbar.js
2 participants
@waltjones @shadow-light