Allow captureIp without a window object #1008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The user IP address is optionally captured at the Rollbar API. The SDK sends a token in the payload signaling whether the captured IP should be added to the payload. This token is added to the payload
request
object, which is only added if a browser window object is detected. (The other keys in the request object depend onwindow.location
.)Setting this token doesn't rely on the
window
object and should be allowed. This is relevant for Electron apps, and for any other client side environment that doesn't supportwindow.location
.This PR allows the request object to be sent with the user IP token, regardless of the presence of
window
orwindow.location
. Tests are added for this condition, as well as for generally correct behavior whenconfig.captureIp
is set.Type of change
Related issues
Fixes #963
Development
Code review