Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow captureIp without a window object #1008

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

waltjones
Copy link
Contributor

Description of the change

The user IP address is optionally captured at the Rollbar API. The SDK sends a token in the payload signaling whether the captured IP should be added to the payload. This token is added to the payload request object, which is only added if a browser window object is detected. (The other keys in the request object depend on window.location.)

Setting this token doesn't rely on the window object and should be allowed. This is relevant for Electron apps, and for any other client side environment that doesn't support window.location.

This PR allows the request object to be sent with the user IP token, regardless of the presence of window or window.location. Tests are added for this condition, as well as for generally correct behavior when config.captureIp is set.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes #963

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request

@waltjones waltjones requested review from cyrusradfar and ijsnow March 21, 2022 20:43
Copy link
Contributor

@ijsnow ijsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

captureIp has no effect for Electron apps
2 participants