This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
fix: ignore virtual modules from other plugins #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukastaegert
reviewed
Aug 9, 2018
|
Added a test to the PR. Should be good to go now. |
|
Was fighting with this yesterday and just found this pull request. Glad it's fixed. Any chance the fix could get released soon? |
|
Scratch that. Looks like it has been released (new tag just doesn't show up on github for some reason). |
|
Good point, forgot to push the tags this morning. Should be there now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315
All tests passing, but maybe need a new one?