Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating review requests for git changes #132

Open
rutwickjain-zz opened this issue Apr 9, 2014 · 3 comments
Open

Support creating review requests for git changes #132

rutwickjain-zz opened this issue Apr 9, 2014 · 3 comments

Comments

@rutwickjain-zz
Copy link

Hey,

I created a test Git repository for POC. I am trying to integrated Git repository with ereviewboard through Eclipse(Juno version).

I installed it through this link --> http://rombert.github.com/ereviewboard/update/
Plus, I installed subclipse integration through this link --> http://subclipse.tigris.org/update_1.6.x

I am able to add a task repository for my reviewboard server and even got it validated. I also created a task query and it fetch the already created review requests. It worked till here.

Now, I made some changes in my file( in Eclipise IDE) . I added it to the index and even committed it (without pushing the changes back to origin ).

Now, the blocker is that I am unable to see "Create review-request" option when I right click on my project tab or any changed file.

Can you guide me to the right way ?

Moreover, I have read that ereviewboard doesn't support Git. Please confirm this.

I have installed EGit for Eclipise and Git integration. And I also selected the ereviewboard sub-module for EGIt during the installation and it was installed successfully.

Thanks,
Rutwick

@rombert
Copy link
Owner

rombert commented Apr 9, 2014

Thanks for the report. Right now we don't support creating review requests from Git.

Is this something that you're willing to contribute? I am happy to guide you through the process.

@rutwickjain-zz
Copy link
Author

Oh, thanks for the confirmation.

I am not a developer. Not sure if I would be able to contribute with my current skills. But still, let me know the process to do so. I can try at-least.

@rombert
Copy link
Owner

rombert commented Apr 11, 2014

@rutwickjain - I see that you closed this issue. I think this is a valid scenario so I'm keeping it open.

As for contributing the changes yourself, I'd be happy to help, although it's not going to be simple. First step would be to perform a git clone of the repository and import it to Eclipse. You need a recent version of Eclipse ( Kepler? ) and m2e installed. After the projects are imported you will be prompted to install additional plug-ins. After restarting, double-click the ereviewboard.target file and set it as the target platform. At this point everything should compile just fine and you should be able to start making changes.

@rombert rombert changed the title Unable to see "Create review request" under menu for Git Repo Support creating review requests for git Apr 11, 2014
@rombert rombert changed the title Support creating review requests for git Support creating review requests for git changes Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants