Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When query is use "to the user" it also filter all task from group #148

Open
centy opened this issue Jul 29, 2015 · 1 comment
Open

When query is use "to the user" it also filter all task from group #148

centy opened this issue Jul 29, 2015 · 1 comment

Comments

@centy
Copy link

centy commented Jul 29, 2015

When new query is created and filtered "to the user" it also will filter all reviews which are not directly to the user but also user is member of some group that is added to the review.
This seems to be incorrect. Our team always set everyone group to each review, however only directly points persons who should do the review. Currently I am not able to filter out reviews directly to me.

@rombert
Copy link
Owner

rombert commented Jul 30, 2015

The query implementation is done in the [ToUserReviewRequestQuery|https://github.com/rombert/ereviewboard/blob/master/org.review_board.ereviewboard.core/src/org/review_board/ereviewboard/core/model/ToUserReviewRequestQuery.java], which uses the to-users parameter from the API.

The fix would be to allow usage of theto-users-directly parameter in parallel to the existing behaviour. Is this something that you would be willing to submit a PR for? I would be happy to guide you through the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants