Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated warnings #4

Open
gf3 opened this issue Apr 25, 2016 · 2 comments
Open

Repeated warnings #4

gf3 opened this issue Apr 25, 2016 · 2 comments

Comments

@gf3
Copy link

gf3 commented Apr 25, 2016

When a component is re-rendered the warnings for any child components are displayed again. This can be quite noisy (e.g. when a component is re-rendered on keyboard input). Perhaps warnings should be cached by warning type + DOM node and only displayed once?

screen shot 2016-04-25 at 9 58 50 am

@romeovs
Copy link
Owner

romeovs commented May 10, 2016

Hmm, this would actually be hard to d without also keeping information on exactly why the rule failed (eg. what values do the props have that cause the rule to fail), or we might miss some errors. This would be a big refactor (every test would need to be rewritten), so not a real priority as of yet.

From the screenshot it seems that you are re-rendering the same components over and over again, perhaps you should consider trying to reduce re-renders. Of course fixing the error or disabling the rule would be a quick way to alleviate this problem.

@erin-doyle
Copy link
Collaborator

There is a bit of a "feature" that could be considered here. The amount of noise and pain it causes when you don't meet a11y standards really motivates you to fix the issue. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants