This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Adding .menu-item class to all <li> tags in walker #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👌🏻 Specificity of |
retlehs
added a commit
that referenced
this pull request
Sep 23, 2015
Adding .menu-item class to all <li> tags in walker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking, it's much easier to target
.menu-itemthan it is to target> li, and probably more performant (albeit marginally so).Was talking to the team and we all thought it wouldn't hurt to add, as the markup is still clean, but now just a little bit easier to use/work with.