Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realtime action server goal handle. #4

Merged
merged 1 commit into from
Aug 28, 2013

Conversation

adolfo-rt
Copy link
Member

  • Factored out from PR2's implementation of the JointTrajectoryActionController.

This is a prerequisite for the Joint Trajectory Controller

- Factored out from PR2's implementation of the JointTrajectoryActionController.
@davetcoleman
Copy link
Member

I don't exactly understand what makes this action server handle real time, but I suppose you wrap this within another realtime tool?

@adolfo-rt
Copy link
Member Author

The runNonRealtime() method has to be executed from a non-realtime thread, and is meant to be called periodically by a timer event.

I admit to the class not being documented and not explaining its usage, another todo...

Originally this was part of the PR2's controller, but my thought was that it could be useful in other controllers. If the usecase seems too narrow and specific, I'd consider adding this file to the JointTrajectoryController package instead of here.

@davetcoleman
Copy link
Member

my thought was that it could be useful in other controllers.

Yes, I think this was a good thought. It make sense to me now, I think it should be merged.

@adolfo-rt
Copy link
Member Author

Ping. I'm not a collaborator in this repo, so I can't merge this PR.

ahendrix added a commit that referenced this pull request Aug 28, 2013
Add realtime action server goal handle.
@ahendrix ahendrix merged commit afff71f into ros-controls:hydro-devel Aug 28, 2013
@adolfo-rt
Copy link
Member Author

Thanks @ahendrix

@ahendrix
Copy link
Contributor

Released as 1.8.2: ros/rosdistro#1901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants