Various cleanups for the ROS 2 branch #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the v4l2 structures, and ensures we don't get sign warnings when compiling. Signed-off-by: Chris Lalancette <[email protected]>
This matches what ioctl actually takes, and gets rid of a sign comparison warning. Signed-off-by: Chris Lalancette <[email protected]>
This just quiets the compiler warnings. Signed-off-by: Chris Lalancette <[email protected]>
|
CI is failing on rolling because image_transport_plugins isn't currently building on the ROS 2 buildfarm: https://build.ros2.org/job/Rbin_uJ64__image_transport_plugins__ubuntu_jammy_amd64__binary/ . Once that is resolved, CI should be able to proceed here. |
Signed-off-by: Chris Lalancette <[email protected]>
|
And CI is now happy here, so I think we can proceed. |
|
Fantastic, thanks for merging! Would you mind doing a new release into Rolling? |
|
@clalancette sure! Give me a few days to find some time |
|
@clalancette here is the open PR to |
Thanks, appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to build this package against the latest Rolling sources, I ran into a number of warnings. This PR fixes some of them. The rest of the warnings are about the use of deprecated FFMPEG functions, which will need a deeper look to fix.