Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav2 Docking: Optional Collision Checking on undocking / docking #4404

Closed
SteveMacenski opened this issue Jun 8, 2024 · 3 comments
Closed
Labels
good first issue Good for newcomers

Comments

@SteveMacenski
Copy link
Member

Should be straight forward: check the future trajectory from the graceful controller for collisions, ignoring within some tolerance of the dock itself (since we're making or in contact there). We can use the costmap collision topic object from the costmap package analog to the Behavior Server's use.

@ajtudela
Copy link
Contributor

Assign me this as it is the same behavior mentioned here: open-navigation/opennav_docking#43. I can do both at the same time.

@SteveMacenski
Copy link
Member Author

Lets add this in a separate PR containing just this work though, don't want to have franken-PRs that are too large to review / merge. Smaller bite sized pieces are always better. Then that can be used in your work. Might make sense for this to be an independent module used by the controller or something so that it can be unit-tested and deployed elsewhere as needed easily

@SteveMacenski
Copy link
Member Author

Merging imminent, thanks @ajtudela this is a great feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants