Add rosout integration test #1924
Conversation
Signed-off-by: Miaofei <[email protected]>
|
@chapulina Do you know who could review this? |
|
Looking at the referenced PRs, I believe @dirk-thomas is the best candidate. But this will most likely need to wait until after the Foxy release. |
| # https://answers.ros.org/question/251194/rospy-subscriber-needs-sleep-some-time-until-the-first-message-is-received/ | ||
| rospy.sleep(0.5) | ||
|
|
||
| log_levels = [ |
There was a problem hiding this comment.
Consider simplifying the logic by removing the array and copying/pasting the logic for DEBUG, WARN, etc. While considered bad practice for production code, repeating code is OK for tests. This article explains why: https://testing.googleblog.com/2019/12/testing-on-toilet-tests-too-dry-make.html
| 'expected to receive %d log messages but got %d' % (len(log_msgs), len(self.callback_data))) | ||
|
|
||
| # checking contents of messages | ||
| for (callback_data, log_level, log_msg) in zip(self.callback_data, log_levels, log_msgs): |
There was a problem hiding this comment.
This makes the assumption that callback calls will never be reordered. Do we have such guarantee in ros_comm for local communication?
You could as well search whether the data is in the vector, to remove this assumption. It'll be closer to what I think you're trying to test here (is the data here?) vs what the test implements (is the data processed exactly in this order?)
There was a problem hiding this comment.
After taking the suggestion at #1924 (comment), this is no longer an issue.
|
@mm318 let me know if you need help to push this to completion! |
Signed-off-by: Miaofei <[email protected]>
Signed-off-by: Miaofei <[email protected]>
Yes, please! :) |
|
@ros-pull-request-builder retest this please |
|
@dirk-thomas is this PR ready? |
Hi @dirk-thomas, looks like the retest has finished and all the tests have passed, so I think this pull request is ready to be merged. |
|
Thanks for the new test. |
As a follow-up to #1913 and #1915, this add a test for ensuring that the
rospy.log*()functions are properly publishing log messages to the/rosouttopic.