Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gif image thumbs from NED are broken #43

Open
jonroberts opened this issue Apr 30, 2013 · 2 comments
Open

.gif image thumbs from NED are broken #43

jonroberts opened this issue Apr 30, 2013 · 2 comments

Comments

@jonroberts
Copy link
Collaborator

So this is a different issue than the one before. Some image thumbnails from NED are broken. For example: 4U 1630-47 up and right from the middle of the galaxy.

The thumbnail is: http://ned.ipac.caltech.edu/dss/4U_1630-47.gif

This is a broken link until we visit the NED info page, at which point it is generated. From that point on the image works. It must be a temp image generated by NED on demand.

Ideally we need to store the NED .gif thumbs locally and set the image_url to the local store.

@jhn
Copy link
Collaborator

jhn commented May 1, 2013

I'm actually getting a few 404s on the console plus the images end up linking to the home path. eg.:
LBQS 2209-1842,
GRB100316D

Others redirect back to the root path without throwing any 404. eg.:
Abell 3266,
MCG-05-18-002,
NGC 5204,
SDSSJ082628.17+152308.1,
3C454.3

@jonroberts
Copy link
Collaborator Author

I've reverted the image reference to the original one - built by javascript. I'll need to pick Ross's brains about why the url wasn't being populated by reference_url properly.

I've also provided a default image for the case where the image url is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants