Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion block don't executed if url is nil #505

Closed
Vitalii-Gozhenko opened this issue Sep 19, 2013 · 1 comment
Closed

Completion block don't executed if url is nil #505

Vitalii-Gozhenko opened this issue Sep 19, 2013 · 1 comment
Labels
bug
Milestone
3.7.0

Comments

@Vitalii-Gozhenko
Copy link

Completion block at setImageWithURL:...... never executed if url is nil. But I usually handle all error in the completion block. Is it possible execute completion block with error some like "incorrect url" or "url is nil"?
@bpoplauschi
Copy link
Member

Agree. We should fix this.

@bpoplauschi bpoplauschi added this to the 3.7.0 milestone Jun 11, 2014
devedup pushed a commit to FilmFlexMovies/SDWebImage that referenced this issue Sep 10, 2014
@bpoplauschi @devedup
Returning error in setImage completedBlock if the url was nil. Added …
d4dc821 
…`dispatch_main_async_safe` macro. Fixes SDWebImage#505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@bpoplauschi @Vitalii-Gozhenko