Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle a specialized addition to bookdown? #671

Open
dmurdoch opened this issue Jan 18, 2019 · 0 comments · May be fixed by #672
Open

How to handle a specialized addition to bookdown? #671

dmurdoch opened this issue Jan 18, 2019 · 0 comments · May be fixed by #672
Labels
feature a feature request or enhancement next to consider for next release

Comments

@dmurdoch
Copy link
Contributor

This question on StackOverflow asks for a very specialized addition to bookdown to support the Hungarian language: rather than \ref in LaTeX, it needs \aref from the babel-magyar package (or something like that), because Hungarian has special grammatical rules for dealing with numbers.

I wrote a tiny package that monkey-patches bookdown when loaded to support @aref as well as @ref. It's a pretty fragile solution, because as soon as bookdown updates one of the patched functions, my package will also need an update. I could submit a PR to incorporate the code into the main bookdown, but I suspect there aren't really that many Hungarian users, and I doubt if the bookdown authors want to support this. And there are a lot of languages, so there are probably other specialized patches that others would want.

So what would be a good strategy for going forward with this?

@dmurdoch dmurdoch linked a pull request Jan 19, 2019 that will close this issue
@cderv cderv added the feature a feature request or enhancement label Mar 24, 2021
@cderv cderv linked a pull request Mar 24, 2021 that will close this issue
@cderv cderv added the next to consider for next release label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement next to consider for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants