Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support meta chars for StartWith and EndWith cops #107

Conversation

koic
Copy link
Member

@koic koic commented May 13, 2020

This PR supports regexp metacharacter ^ for Performance/StartWith cop and regexp metacharacter $ for Performance/EndWith cop.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the support_end_meta_chars_for_start_with_and_end_with_cops branch 2 times, most recently from 56cb483 to b0f8bc5 Compare May 13, 2020 16:28
This PR supports regexp metacharacter `^` for `Performance/StartWith` cop
and regexp metacharacter `$` for `Performance/EndWith` cop.
@koic koic force-pushed the support_end_meta_chars_for_start_with_and_end_with_cops branch from b0f8bc5 to 7afe5f2 Compare May 13, 2020 16:30
@koic koic merged commit 96498b3 into rubocop:master May 16, 2020
@koic koic deleted the support_end_meta_chars_for_start_with_and_end_with_cops branch May 16, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant