Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Performance/Detect cop with check for filter method and Performance/Count cop with checks for find_all and filter methods #157

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

fatkodima
Copy link
Contributor

Closes #63

I have rechecked existing Detect and Count cops - they are handling almost everything that is needed/requested (as mentioned in #63 (comment)).

So implemented checks for 2 missing methods in this PR.

…erformance/Count` cop with checks for `find_all` and `filter` methods
@koic koic merged commit 8bf09de into rubocop:master Aug 31, 2020
@koic
Copy link
Member

koic commented Aug 31, 2020

filter method has been added in Ruby 2.6, it may be necessary to add a version condition, but let's try early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Performance/SelectFirst
2 participants