Version 2.3.1+ doesn't seem to respect "inherit_mode"

[lucascaton]

Expected behavior

Since rubocop-rails 2.3.1 (also tested with 2.3.2), Rubocop is complaining about some offenses that should be ignored by default (node_modules/node-sass/src/libsass/contrib/libsass.spec) for example.

rubocop-rails 2.3.0 and previous versions didn't have this issue and I believe it started after this change.

Actual behavior

As I'm using inherit_mode, Rubocop shouldn't raise any offenses:

inherit_mode:
  merge:
    - Exclude

However, it does (after updating rubocop-rails), please see the following example.

Steps to reproduce the problem

This is my .rubocop.yml:

inherit_from: .rubocop_todo.yml

require:
  - rubocop-performance
  - rubocop-rails
  - rubocop-rspec

inherit_mode:
  merge:
    - Exclude

AllCops:
  TargetRubyVersion: 2.6

  Exclude:
    - 'db/schema.rb'

Rails:
  Enabled: true

# etc...

In order to reproduce the issue:

rubocop # with rubocop-rails 2.3.0
# 270 files inspected, no offenses detected

rubocop # with rubocop-rails 2.3.1
# 270 files inspected, 54 offenses detected

RuboCop version

$ [bundle exec] rubocop -V
0.74.0 (using Parser 2.6.4.0, running on ruby 2.6.4 x86_64-darwin18)

Please let me know if I can provide more info in order to help. Thank you.

[palkan]

Also faced this issue. Putting inherit_mode at the top of the .rubocop.yml doesn't help (or should it?)

[ghost]

Hi there. Any news on this?

[ghost]

I can confirm version 2.3.2 has the same bug.

[mpm]

Same issue here. I have no clue about Rubocop extensions, but I suspect that the inherit_mode directive only applies to the the configuration stuff that is processed or directly referenced in your local .rubocop.yml?

So, if you would just use inherit_from and reference the config file from the gem, it would work.

But that is not possible, because it wouldn't load all the code for the necessary Cops.
So, when instead using require, the config file is loaded by rubocop-rails directly, so you cannot influence the inherit mode.

I suspect that merging the config happens somewhere here.

The merge only takes care of merging keys inside the hash, not the values of the keys (they are replaced). So, since the exclusion list is a list, it is just overriden...

I found this PR in Rubocop which seems to deal with this, maybe this interferes because a related method is monkey patched by rubocop-rails?

[ghost]

I can confirm version 2.4.0 has the same bug.

[lucascaton]

Thanks @koic, but the issue still happens on version 2.4.1.
The steps to reproduce are the same as described in this issue description.

[koic]

I will release RuboCop Rails 2.4.2 soon. It will be fixed in that version.

[lucascaton]

Sorry @koic - I looked at the CHANGELOG and thought 2.4.1 included this fix. My bad 🤦‍♂️

[koic]

FYI, RuboCop Rails 2.4.2 has been released. Thank you!
https://github.com/rubocop-hq/rubocop-rails/releases/tag/v2.4.2