Rails/RenderInline: undefined method `value'

[elv1ss]

Expected behavior

RoboCop should ignore key-value pairs where the key is represented as a variable.

Actual behavior

The error undefined method 'value' for s(:lvar, :serializer):RuboCop::AST::Node occurs when Rails/RenderInline cop check render json: ... line with hash where the key is represented as a variable.

Steps to reproduce the problem

Run RuboCop on the following:

class DemoController
  def index
    render_for(@resources)
  end

  def show
    render_for(@resource)
  end

  private

  def render_for(resource, includes: '**')
    serializer = resource.respond_to?(:each) ? :each_serializer : :serializer
    render json: resource, serializer => ResourceSerializer, include: includes
  end
end

RuboCop version

bundle exec rubocop -V
0.88.0 (using Parser 2.7.1.4, rubocop-ast 0.2.0, running on ruby 2.6.6 x86_64-darwin18)

Possible fix

I think this can be fixed by adding respond_to check to includes_inline_key? method, but I'm not sure.

def includes_inline_key?(node)
  node.keys.find { |key| key.respond_to?(:value) && key.value.to_sym == :inline }
end