[Fix #404] Make Rails/HelperInstanceVariable accept of instance variables
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Dec 11, 2020
andyw8
reviewed
Dec 11, 2020
koic
force-pushed
the
make_rails_helper_instance_variable_accept_of_ivar
branch
2 times, most recently
from
b078c62
to
d92dcc9
Compare
…nce variables Fixes rubocop#404. This PR makes `Rails/HelperInstanceVariable` accept of instance variables when class inherited `ActionView::Helpers::FormBuilder`. It may be too broad to accept all instance variables, but view helper and form builder have different uses, so let's take a look first.
koic
force-pushed
the
make_rails_helper_instance_variable_accept_of_ivar
branch
from
d92dcc9
to
4741d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404.
This PR makes
Rails/HelperInstanceVariableaccept of instance variables when class inheritedActionView::Helpers::FormBuilder.It may be too broad to accept all instance variables, but view helper and form builder have different uses, so let's take a look first.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.