Fix the issue that excluded files in rubocop-rails did not work #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinsoku
force-pushed
the
make_excludes_absolute
branch
from
adb09a7
to
788d153
Compare
|
I guess it is not a rubocop-rails specific problem. So I will apply this change to also rubocop-extension-generator. And I've confirmed that other plugins do not have |
sinsoku
force-pushed
the
make_excludes_absolute
branch
from
788d153
to
ce5ecf7
Compare
sinsoku
changed the title
sinsoku
force-pushed
the
make_excludes_absolute
branch
from
ce5ecf7
to
aa3ab45
Compare
koic
reviewed
Jan 18, 2020
sinsoku
force-pushed
the
make_excludes_absolute
branch
from
aa3ab45
to
9d88d1f
Compare
`bin/*` and `db/schema.rb` were not excluded. Exclude files should be absolute paths internally, so it fixes to call the `make_excludes_absolute` method. Ref: rubocop/rubocop@cb63798
sinsoku
force-pushed
the
make_excludes_absolute
branch
from
9d88d1f
to
61b7567
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/*anddb/schema.rbwere not excluded.Exclude files should be absolute paths internally, so it fixes to call the
make_excludes_absolutemethod.Ref: rubocop/rubocop@cb63798
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.