Mark Rails/ApplicationController and similar cops as unsafe autocorrect
#223
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoshinotsuyoshi
force-pushed
the
application-controller-unsafe
branch
2 times, most recently
from
6cc2ff3
to
f6035f0
Compare
koic
reviewed
Apr 1, 2020
| @@ -57,21 +57,25 @@ Rails/ActiveSupportAliases: | |||
| Rails/ApplicationController: | |||
| Description: 'Check that controllers subclass ApplicationController.' | |||
| Enabled: true | |||
| SafeAutoCorrect: false | |||
| VersionAdded: '2.4' | |||
There was a problem hiding this comment.
Can you mark VersionChanged: '2.5'?
Suggested change
| VersionAdded: '2.4' | |
| VersionAdded: '2.4' | |
| VersionChanged: '2.5' |
Same for other changes.
There was a problem hiding this comment.
Thx, updated && rebased && force-pushed a1aa7d5
…rect
We have a controller class which inherits `ActionController::Base` directly.
That controller is for health check endpoint.
```ruby
class HealthCheckController < ActionController::Base
# we want to skip some authentication logics...
def index
head :ok
end
end
```
```ruby
class ApplicationController < ActionController::Base
# default some authentication logics...
end
```
In such case, automatically modifying the `ActionController :: Base`->` ApplicationController` is not safe .
hoshinotsuyoshi
force-pushed
the
application-controller-unsafe
branch
from
f6035f0
to
a1aa7d5
Compare
|
This change looks good to me. Thanks for showing the use case for unsafe auto-correction. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a controller class which inherits
ActionController::Basedirectly.That controller is for health check endpoint.
In such case, automatically modifying the
ActionController :: Base->ApplicationControlleris not safe .Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.