Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Ruby 2.3 #233

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Drop support for Ruby 2.3 #233

merged 1 commit into from
Apr 13, 2020

Conversation

koic
Copy link
Member

@koic koic commented Apr 13, 2020

Follow rubocop/rubocop#7869.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the drop_support_for_ruby_2_3 branch from 44aad9f to 30cdec9 Compare April 13, 2020 12:37
@koic koic merged commit 38840dd into rubocop:master Apr 13, 2020
@koic koic deleted the drop_support_for_ruby_2_3 branch April 13, 2020 15:35
koic added a commit that referenced this pull request Jun 11, 2020
@koic
Use match?
6c9224d 
Follow up #233.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@koic