Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ENV.update calls in Rails/SaveBang #248

Merged
merged 1 commit into from
May 25, 2020

Conversation

eugeneius
Copy link
Contributor

We can't detect Hash#update false positives in the general case, but when the receiver is ENV we know it's not an Active Record instance.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

We can't detect `Hash#update` false positives in the general case, but
when the receiver is `ENV` we know it's not an Active Record instance.
@koic
Copy link
Member

koic commented May 25, 2020

Make sense 🌟

@koic koic merged commit bd44759 into rubocop:master May 25, 2020
@eugeneius
Copy link
Contributor Author

Wow that was fast 😄 thanks for the review as always @koic 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants