Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick(...)
is a shorthand forpluck(...).first
.https://api.rubyonrails.org/classes/ActiveRecord/Calculations.html#method-i-pick
This cop is unsafe because
pluck
is defined on bothActiveRecord::Relation
andEnumerable
, whereaspick
is only defined onActiveRecord::Relation
in Rails 6.0. This will be addressed in Rails 6.1 via rails/rails#38760, at which point the cop will be safe. I don't know if there's currently a way to apply a different default configuration based on the Rails version, but I'd be happy to investigate that once Rails 6.1 is released.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.