Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Rails.root interpolation at end of string #251

Merged
merged 1 commit into from
May 26, 2020

Conversation

eugeneius
Copy link
Contributor

This cop looks for file paths constructed manually by interpolating Rails.root into a string. It currently assumes that some literal characters will follow that interpolation, which isn't always the case.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This cop looks for file paths constructed manually by interpolating
`Rails.root` into a string. It currently assumes that some literal
characters will follow that interpolation, which isn't always the case.
@koic koic merged commit b018933 into rubocop:master May 26, 2020
@koic
Copy link
Member

koic commented May 26, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants