Add new Rails/PluckId cop

[fatkodima]

https://rails.rubystyle.guide/#ids

[fatkodima]

Updated.

[koic]

Is it as expected to prioritize this Rails/PluckId cop over Rails/PluckInWhere cop when using auto-correction?

% cat app/models/example.rb
class Foo < ApplicationRecord
  def bar
    Bar.where(baz_id: Baz.pluck(:id))
  end
end

% bundle exec rubocop app/models/example.rb -A --only Rails/PluckInWhere,Rails/PluckId
(snip)

Inspecting 1 file
C

Offenses:

app/models/example.rb:3:27: C: [Corrected] Rails/PluckId: Use ids instead of pluck(:id).
    Bar.where(baz_id: Baz.pluck(:id))
                          ^^^^^^^^^^
app/models/example.rb:3:27: C: [Corrected] Rails/PluckInWhere: Use select instead of pluck within where query method.
    Bar.where(baz_id: Baz.pluck(:id))
                          ^^^^^

1 file inspected, 2 offenses detected, 2 offenses corrected

% cat app/models/example.rb
class Foo < ApplicationRecord
  def bar
    Bar.where(baz_id: Baz.ids)
  end
end

[fatkodima]

Thanks! This is not expected. Updated the code to check if in where and added a test case for this.

[fatkodima]

Updated.

[koic]

Thanks!