Preserve original callback execution order #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneius
commented
Jul 30, 2020
|
|
||
| ### Changes | ||
|
|
||
| * [#312](https://github.com/rubocop-hq/rubocop-rails/pull/312): Mark `Rails/MailerName` as unsafe for auto-correct. ([@eugeneius][]) |
There was a problem hiding this comment.
I added this in the wrong place in #312. 😩
This cop registers an offense when a callback appears after another callback that will be executed later in the record's lifecycle. The auto-correct logic currently always moves the offending callback to before the first callback in the class. This does eventually produce the correct result, but it's not very efficient, and can reorder callbacks of the same type, which changes the order in which they're executed. By moving the offending callback above the preceding one, the sort becomes stable and the original callback execution order is preserved.
eugeneius
force-pushed
the
preserve_callback_order
branch
from
f988cee
to
9300bbe
Compare
eugeneius
commented
Jul 30, 2020
| CALLBACKS_ORDER_MAP = Hash[ | ||
| CALLBACKS_IN_ORDER.map.with_index { |name, index| [name, index] } | ||
| ].freeze | ||
| CALLBACKS_ORDER_MAP = CALLBACKS_IN_ORDER.each_with_index.to_h.freeze |
There was a problem hiding this comment.
This change isn't necessary to fix the problem, but I thought it was a nice simplification. 🙂
I'll happily take it out if it's not welcome, though.
|
Great! Thank you always 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop registers an offense when a callback appears after another callback that will be executed later in the record's lifecycle.
The auto-correct logic currently always moves the offending callback to before the first callback in the class. This does eventually produce the correct result, but it's not very efficient, and can reorder callbacks of the same type, which changes the order in which they're executed.
By moving the offending callback above the preceding one, the sort becomes stable and the original callback execution order is preserved.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.