Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle to_h with block in Rails/IndexBy and Rails/IndexWith #324

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

eugeneius
Copy link
Contributor

Followup to #208.
See also rubocop/rubocop#8517.

Since Ruby 2.6, Enumerable#to_h accepts a block which is called with each element and must return a key and value to include in the new hash: https://rubyreferences.github.io/rubychanges/2.6.html#to_h-with-a-block

If the element is always returned as either the key or the value, using Enumerable#index_by or Enumerable#index_with is faster and clearer.

This is similar to the existing logic that detects map { ... }.to_h.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Since Ruby 2.6, `Enumerable#to_h` accepts a block which is called with
each element and must return a key and value to include in the new hash.

If the element is always returned as either the key or the value, using
`Enumerable#index_by` or `Enumerable#index_with` is faster and clearer.

This is similar to the existing logic that detects `map { ... }.to_h`.
@eugeneius eugeneius force-pushed the index_by_index_with_to_h_with_block branch from 78daa59 to 98c6570 Compare August 11, 2020 15:43
@koic koic merged commit d6cd35f into rubocop:master Aug 11, 2020
@koic
Copy link
Member

koic commented Aug 11, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants