Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors of Rails/UniqueValidationWithoutIndex #349

Merged

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Sep 8, 2020

Rails/UniqueValidationWithoutIndex dies with following error:

When the table does not exist:

An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting <filename>.
undefined method `each_node' for nil:NilClass
.../lib/rubocop/cop/mixin/active_record_helper.rb:14:in `find_set_table_name'

When defining module instead of class:

An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting <filename>.
undefined method `with_column?' for nil:NilClass
.../lib/rubocop/cop/mixin/active_record_helper.rb:55:in `resolve_relation_into_column'

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

- When the table does not exist.
- When defining `module` instead of `class`.
@Tietew Tietew force-pushed the unique_validation_without_index_error_fix branch from fd69c9d to 095a126 Compare September 8, 2020 07:54
jkeck added a commit to sul-dlss/dlme that referenced this pull request Sep 8, 2020
jkeck added a commit to sul-dlss/dlme that referenced this pull request Sep 8, 2020
cbeer pushed a commit to sul-dlss/dlme that referenced this pull request Sep 8, 2020
@koic koic merged commit fa637ca into rubocop:master Sep 9, 2020
@koic
Copy link
Member

koic commented Sep 9, 2020

Thanks!

@Tietew Tietew deleted the unique_validation_without_index_error_fix branch September 10, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants