Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false negatives for Rails/EnumUniqueness cop #97

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Fix false negatives for Rails/EnumUniqueness cop #97

merged 1 commit into from
Aug 9, 2019

Conversation

santib
Copy link
Contributor

@santib santib commented Jul 28, 2019

Fixing Rails/EnumUniqueness cop per conversation in #96 (comment)

@koic
Copy link
Member

koic commented Jul 29, 2019

Could you add a changelog entry to CHANGELOG.md what kind of false negative has been fixed?

@santib santib force-pushed the fix-enum-uniqueness branch 2 times, most recently from ebba1b4 to 67f374c Compare July 29, 2019 23:12
@santib
Copy link
Contributor Author

santib commented Jul 29, 2019

@koic Rebased with master and added an entry to the changelog

@koic koic merged commit 83cdf0d into rubocop:master Aug 9, 2019
@koic
Copy link
Member

koic commented Aug 9, 2019

Thanks!

@touhouota touhouota mentioned this pull request Aug 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santib @koic