Add new cop Style/FloatDivision
#7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jun 19, 2019
koic
reviewed
Jun 19, 2019
koic
reviewed
Jun 19, 2019
tejasbubane
force-pushed
the
float-division
branch
3 times, most recently
from
2e9cf2e
to
c7ba4b0
Compare
bquorning
reviewed
Jun 19, 2019
tejasbubane
force-pushed
the
float-division
branch
from
c7ba4b0
to
a1712bc
Compare
tejasbubane
force-pushed
the
float-division
branch
from
a1712bc
to
1c48371
Compare
|
After some deliberation I agree with @koic that the best default would be something that just warns if you use |
|
See also https://blog.rubystyle.guide/ruby/2019/06/21/float-division.html - unfortunately we got no feedback on it. |
koic
added a commit
to koic/ruby-style-guide
that referenced
this pull request
Jun 22, 2019
This PR updates a style guide for "Float Division". The original issue for which this style was proposed. rubocop#628 It is an update based on the following argument. rubocop/rubocop#7153 (comment) The following is a quote from the argument about the reason for this change. > I wanted to show the following option to make a bad case only when both have `to_f`. > > ```ruby > # bad > a.to_f / b.to_f > > # good > a.to_f / b > a / b.to_f > a.fdiv(b) > ``` > > Whether `to_f` is used on the left or right depends on the nature of `a` > or `b` parameter. On the other hand, it is redundant that `to_f` is used > in both. At that time, I think it is better to let users choose whether > to remove the left side `to_f` or the right side `to_f`. This is the > reason I recommend this option to default.
|
Thanks for your consideration. I opened a PR rubocop/ruby-style-guide#767 to rubocop-hq/ruby-style-guide repo. |
bbatsov
pushed a commit
to rubocop/ruby-style-guide
that referenced
this pull request
Jun 22, 2019
This PR updates a style guide for "Float Division". The original issue for which this style was proposed. #628 It is an update based on the following argument. rubocop/rubocop#7153 (comment) The following is a quote from the argument about the reason for this change. > I wanted to show the following option to make a bad case only when both have `to_f`. > > ```ruby > # bad > a.to_f / b.to_f > > # good > a.to_f / b > a / b.to_f > a.fdiv(b) > ``` > > Whether `to_f` is used on the left or right depends on the nature of `a` > or `b` parameter. On the other hand, it is redundant that `to_f` is used > in both. At that time, I think it is better to let users choose whether > to remove the left side `to_f` or the right side `to_f`. This is the > reason I recommend this option to default.
koic
reviewed
Jun 22, 2019
tejasbubane
force-pushed
the
float-division
branch
from
1c48371
to
6f2dc54
Compare
|
@koic PR updated. Changed default style to |
koic
reviewed
Jun 24, 2019
tejasbubane
force-pushed
the
float-division
branch
from
6f2dc54
to
c5708ae
Compare
tejasbubane
force-pushed
the
float-division
branch
from
c5708ae
to
8165649
Compare
koic
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StyleGuide: https://rubystyle.guide/#float-division
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.