Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Minitest/AssertEqual aware of assert_operator #266

Conversation

koic
Copy link
Member

@koic koic commented Oct 1, 2023

This PR makes Minitest/AssertEqual aware of assert_operator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the make_minitest_assert_equal_aware_of_assert_operator branch 2 times, most recently from 9d2b232 to 93e3502 Compare October 2, 2023 05:12
This PR makes `Minitest/AssertEqual` aware of `assert_operator`.
@koic koic force-pushed the make_minitest_assert_equal_aware_of_assert_operator branch from 93e3502 to 060e7a0 Compare October 6, 2023 15:53
RUBY
end

# Redundant parentheses should be removed by `Style/RedundantParentheses` cop.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This case will be solved by rubocop/rubocop#12247.

@koic koic merged commit aba8cff into rubocop:master Oct 8, 2023
4 checks passed
@koic koic deleted the make_minitest_assert_equal_aware_of_assert_operator branch October 8, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant