Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Performance/MapCompact aware of safe navigation operator #389

Closed
ydakuka opened this issue Nov 24, 2023 · 0 comments · Fixed by #391
Closed

Make Performance/MapCompact aware of safe navigation operator #389

ydakuka opened this issue Nov 24, 2023 · 0 comments · Fixed by #391

Comments

@ydakuka
Copy link
Contributor

ydakuka commented Nov 24, 2023

Describe the solution you'd like

# bad
def my_method
  User.find_by(value: value)
      &.map(&:enabled)
      &.compact
end
# good
def my_method
  User.find_by(value: value)
      &.filter_map(&:enabled)
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.2 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant