Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #147] Fix an error for Performance/AncestorsInclude #148

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jul 9, 2020

Fixes #147.

This PR fixes an error for Performance/AncestorsInclude when using ancestors.include? without receiver.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_error_for_performance_ancestors_include branch from 1600d30 to 8537694 Compare July 9, 2020 10:27
Fixes rubocop#147.

This PR fixes an error for `Performance/AncestorsInclude`
when using `ancestors.include?` without receiver.
@koic koic force-pushed the fix_error_for_performance_ancestors_include branch from 8537694 to 839e35b Compare July 11, 2020 07:10
@koic koic merged commit 337d869 into rubocop:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance/AncestorsInclude with auto correct raises error
2 participants