Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Performance/RedundantMerge as unsafe #228

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Mar 29, 2021

As per https://twitter.com/bbatsov/status/1376631309020315654

Performance/RedundantMerge makes the following autocorrection:

-    @operation_builder.merge!(foobar: [{name: "passed_option"}])
+    @operation_builder[:foobar] = [{name: "passed_option"}]

But if @operation_builder here is not a hash, this is a bad correction, thus making the cop unsafe.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic merged commit f7de801 into rubocop:master Mar 29, 2021
@koic
Copy link
Member

koic commented Mar 29, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants