Add Performance/MapCompact cop
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_new_map_compact_cop
branch
2 times, most recently
from
963ca2b
to
970d0fb
Compare
8 tasks
Follow rubocop#211 (comment) This PR adds `Performance/MapCompact` cop In Ruby 2.7, `Enumerable#filter_map` has been added. This cop identifies places where `map { ... }.compact` can be replaced by `filter_map`. It is marked as unsafe auto-correction by default because `map { ... }.compact` that is not compatible with `filter_map`. The following is good and bad cases. ```ruby # bad ary.map(&:foo).compact ary.collect(&:foo).compact # good ary.filter_map(&:foo) ary.map(&:foo).compact! ```
koic
force-pushed
the
add_new_map_compact_cop
branch
from
970d0fb
to
77de934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #211 (comment)
This PR adds
Performance/MapCompactcopIn Ruby 2.7,
Enumerable#filter_maphas been added.This cop identifies places where
map { ... }.compactcan be replaced byfilter_map.It is marked as unsafe auto-correction by default because
map { ... }.compactthat is not compatible withfilter_map.The following is good and bad cases.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.