Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 2.4 support #232

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Drop Ruby 2.4 support #232

merged 1 commit into from
Apr 6, 2021

Conversation

koic
Copy link
Member

@koic koic commented Apr 6, 2021

Follow rubocop/rubocop#9648.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic merged commit cae4247 into rubocop:master Apr 6, 2021
@koic koic deleted the drop_ruby_24 branch April 6, 2021 16:53
koic added a commit that referenced this pull request Aug 26, 2021
Follow up to #232.

This commit removes redundant `TargetRubyVersion` because
RuboCop Performance already drops Ruby 2.4 or lower.
koic added a commit to koic/rubocop-performance that referenced this pull request May 15, 2022
koic added a commit to koic/rubocop-performance that referenced this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant