Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in Performance/Sum when method has no brackets #264

Merged
merged 1 commit into from
Oct 16, 2021

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Oct 16, 2021

This fixes an issue where code like the following would cause an error in the Performance/Sum cop:

arr.inject :+

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This fixes an issue where code like the following would cause an error
in the Performance/Sum cop:

  arr.inject :+
@koic koic merged commit ccc9afe into rubocop:master Oct 16, 2021
@koic
Copy link
Member

koic commented Oct 16, 2021

Thanks!

@mvz mvz deleted the fix-sum-cop branch October 16, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants