Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative for Performance/ChainArrayAllocation #294

Conversation

koic
Copy link
Member

@koic koic commented Jun 15, 2022

This PR fixes a false negative for Performance/ChainArrayAllocation when using array.first(do_something).uniq.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes a false negative for `Performance/ChainArrayAllocation`
when using `array.first(do_something).uniq`.
@koic koic force-pushed the fix_false_negative_for_performance_chain_array_allocation branch from 0837b87 to b257411 Compare June 15, 2022 16:03
@koic koic merged commit fd8c7e3 into rubocop:master Jun 16, 2022
@koic koic deleted the fix_false_negative_for_performance_chain_array_allocation branch June 16, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant