Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Performance/StringInclude to handle !~ #319

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

fatkodima
Copy link
Contributor

Closes #318.

@@ -325,7 +325,7 @@ Performance/StringInclude:
Enabled: 'pending'
SafeAutoCorrect: false
VersionAdded: '1.7'
VersionChanged: '1.12'
VersionChanged: '1.16'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert it? Because this update is not required.

Suggested change
VersionChanged: '1.16'
VersionChanged: '1.12'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

@koic koic merged commit a8c96d7 into rubocop:master Dec 2, 2022
@fatkodima fatkodima deleted the string_include-not-match branch December 2, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for !~ to Performance/StringInclude
2 participants