[Fix #48] Fix RegexpMatch false positive #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
commented
May 4, 2019
| ## 1.2.0 (2019-05-04) | ||
|
|
||
| ### Bug fixes | ||
|
|
||
| * [#47](https://github.com/rubocop-hq/rubocop-performance/pull/47): Fix a false negartive for `Performance/RegexpMatch` when using RuboCop 0.68 or higher. ([@koic][]) | ||
| * [#47](https://github.com/rubocop-hq/rubocop-performance/pull/47): Fix a false negative for `Performance/RegexpMatch` when using RuboCop 0.68 or higher. ([@koic][]) |
| @@ -80,14 +80,14 @@ class RegexpMatch < Cop | |||
| # Constants are included in this list because it is unlikely that | |||
| # someone will store `nil` as a constant and then use it for comparison | |||
| TYPES_IMPLEMENTING_MATCH = %i[const regexp str sym].freeze | |||
| MSG = | |||
| 'Use `match?` instead of `%<current>s` when `MatchData` ' \ | |||
| MSG = 'Use `match?` instead of `%<current>s` when `MatchData` ' \ | |||
There was a problem hiding this comment.
This is to resolve a Metrics/ClassLength cop violation.
dduugg
force-pushed
the
fix-regexp_match-falfe-positive
branch
from
1672399
to
446b0be
Compare
koic
reviewed
May 9, 2019
CHANGELOG.md
Outdated
| @@ -2,11 +2,15 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * [#48](https://github.com/rubocop-hq/rubocop-performance/issues/48): Fix false positives in `Performance/RegexpMatch`. ([@dduugg][]) | |||
There was a problem hiding this comment.
Could you write a little more about what false positives have been fixed?
|
This code looks good. Could you please rebase using latest master branch? A warning will probably occur because Ruby 2.2 was dropped. |
dduugg
force-pushed
the
fix-regexp_match-falfe-positive
branch
from
446b0be
to
1c61089
Compare
|
@koic I've updated the changelog to detail the change, and rebased on current master. Please take another look. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes false positives in
Performance/RegexpMatchby only flagging single-argumentmatchmethods where either the receiver or the argument is a literal of typeRegexp,String,Symbol.Resolves #48
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.