Fix an error for Rails/Validation when passing no arguments

rubocop · Aug 22, 2024 · 1efc402 · 1efc402
1 parent 2298948
commit 1efc402
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/fix_error_rails_validation.md b/changelog/fix_error_rails_validation.md
@@ -0,0 +1 @@
+* [#1337](https://github.com/rubocop/rubocop-rails/pull/1337): Fix an error for `Rails/Validation` when passing no arguments. ([@earlopain][])
diff --git a/lib/rubocop/cop/rails/validation.rb b/lib/rubocop/cop/rails/validation.rb
@@ -59,11 +59,11 @@ class Validation < Base
 
         def on_send(node)
           return if node.receiver
+          return unless (last_argument = node.last_argument)
 
           range = node.loc.selector
 
           add_offense(range, message: message(node)) do |corrector|
-            last_argument = node.last_argument
             return if !last_argument.literal? && !last_argument.splat_type? && !frozen_array_argument?(last_argument)
 
             corrector.replace(range, 'validates')

diff --git a/spec/rubocop/cop/rails/validation_spec.rb b/spec/rubocop/cop/rails/validation_spec.rb
@@ -170,4 +170,10 @@
       validates_numericality_of :a, b
     RUBY
   end
+
+  it 'registers no offense when no arguments are passed' do
+    expect_no_offenses(<<~RUBY)
+      validates_numericality_of
+    RUBY
+  end
 end