Merge pull request #1115 from koic/fix_an_incorrect_autocorrect_for_r…

…ails_time_zone [Fix #1108] Fix an incorrect autocorrect for `Rails/TimeZone`
rubocop · Sep 13, 2023 · 8457ca2 · 8457ca2
2 parents a56fb0e + ce6056d
commit 8457ca2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/changelog/fix_an_incorrect_autocorrect_for_rails_time_zone.md b/changelog/fix_an_incorrect_autocorrect_for_rails_time_zone.md
@@ -0,0 +1 @@
+* [#1108](https://github.com/rubocop/rubocop-rails/issues/1108): Fix an incorrect autocorrect for `Rails/TimeZone` when using `String#to_time`. ([@koic][])
diff --git a/lib/rubocop/cop/rails/time_zone.rb b/lib/rubocop/cop/rails/time_zone.rb
@@ -69,7 +69,7 @@ def on_send(node)
           return if !node.receiver&.str_type? || !node.method?(:to_time)
 
           add_offense(node.loc.selector, message: MSG_STRING_TO_TIME) do |corrector|
-            autocorrect(corrector, node)
+            corrector.replace(node, "Time.zone.parse(#{node.receiver.source})")
           end
         end
 

diff --git a/spec/rubocop/cop/rails/time_zone_spec.rb b/spec/rubocop/cop/rails/time_zone_spec.rb
@@ -129,6 +129,10 @@
         "2012-03-02 16:05:37".to_time
                               ^^^^^^^ Do not use `String#to_time` without zone. Use `Time.zone.parse` instead.
       RUBY
+
+      expect_correction(<<~RUBY)
+        Time.zone.parse("2012-03-02 16:05:37")
+      RUBY
     end
 
     it 'does not register an offense for `to_time` without receiver' do