From c0d83ee5278b242a323545686586979c86fd2e5e Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Sat, 30 Sep 2023 14:27:48 +0900 Subject: [PATCH] Update Changelog --- CHANGELOG.md | 9 +++++++++ ...itive_for_rails_redundant_active_record_all_method.md | 1 - changelog/fix_an_error_for_rails_select_map.md | 1 - ..._active_record_all_method_when_all_has_parentheses.md | 1 - changelog/fix_bug_unique_validation_without_index.md | 1 - ...itive_for_rails_redundant_active_record_dll_method.md | 1 - 6 files changed, 9 insertions(+), 5 deletions(-) delete mode 100644 changelog/fix_a_false_positive_for_rails_redundant_active_record_all_method.md delete mode 100644 changelog/fix_an_error_for_rails_select_map.md delete mode 100644 changelog/fix_an_incorrect_autocorrect_for_rails_redundant_active_record_all_method_when_all_has_parentheses.md delete mode 100644 changelog/fix_bug_unique_validation_without_index.md delete mode 100644 changelog/fix_false_positive_for_rails_redundant_active_record_dll_method.md diff --git a/CHANGELOG.md b/CHANGELOG.md index 15c9223da8..eeb675c6df 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,14 @@ ## master (unreleased) +### Bug fixes + +* [#1126](https://github.com/rubocop/rubocop-rails/pull/1126): Fix a false positive for `Rails/RedundantActiveRecordAllMethod` when using some `Enumerable`'s methods with block argument. ([@koic][]) +* [#1121](https://github.com/rubocop/rubocop-rails/issues/1121): Fix an error for `Rails/SelectMap` when using `select(:column_name).map(&:column_name)` without receiver model. ([@koic][]) +* [#1119](https://github.com/rubocop/rubocop-rails/issues/1119): Fix an incorrect autocorrect for `Rails/RedundantActiveRecordAllMethod` when `all` has parentheses. ([@masato-bkn][]) +* [#1130](https://github.com/rubocop/rubocop-rails/issues/1130): Fix crash for `Rails/UniqueValidationWithoutIndex` with bare validate. ([@jamiemccarthy][]) +* [#1124](https://github.com/rubocop/rubocop-rails/issues/1124): Fix false positives for `Rails/RedundantActiveRecordAllMethod` when receiver is not an Active Record model. ([@koic][]) + ## 2.21.1 (2023-09-14) ### Bug fixes @@ -941,3 +949,4 @@ [@fastjames]: https://github.com/fastjames [@nipe0324]: https://github.com/nipe0324 [@marocchino]: https://github.com/marocchino +[@jamiemccarthy]: https://github.com/jamiemccarthy diff --git a/changelog/fix_a_false_positive_for_rails_redundant_active_record_all_method.md b/changelog/fix_a_false_positive_for_rails_redundant_active_record_all_method.md deleted file mode 100644 index b722244ff4..0000000000 --- a/changelog/fix_a_false_positive_for_rails_redundant_active_record_all_method.md +++ /dev/null @@ -1 +0,0 @@ -* [#1126](https://github.com/rubocop/rubocop-rails/pull/1126): Fix a false positive for `Rails/RedundantActiveRecordAllMethod` when using some `Enumerable`'s methods with block argument. ([@koic][]) diff --git a/changelog/fix_an_error_for_rails_select_map.md b/changelog/fix_an_error_for_rails_select_map.md deleted file mode 100644 index 7eab352547..0000000000 --- a/changelog/fix_an_error_for_rails_select_map.md +++ /dev/null @@ -1 +0,0 @@ -* [#1121](https://github.com/rubocop/rubocop-rails/issues/1121): Fix an error for `Rails/SelectMap` when using `select(:column_name).map(&:column_name)` without receiver model. ([@koic][]) diff --git a/changelog/fix_an_incorrect_autocorrect_for_rails_redundant_active_record_all_method_when_all_has_parentheses.md b/changelog/fix_an_incorrect_autocorrect_for_rails_redundant_active_record_all_method_when_all_has_parentheses.md deleted file mode 100644 index 8ef8a53ec4..0000000000 --- a/changelog/fix_an_incorrect_autocorrect_for_rails_redundant_active_record_all_method_when_all_has_parentheses.md +++ /dev/null @@ -1 +0,0 @@ -* [#1119](https://github.com/rubocop/rubocop-rails/issues/1119): Fix an incorrect autocorrect for `Rails/RedundantActiveRecordAllMethod` when `all` has parentheses. ([@masato-bkn][]) diff --git a/changelog/fix_bug_unique_validation_without_index.md b/changelog/fix_bug_unique_validation_without_index.md deleted file mode 100644 index 0acaff7130..0000000000 --- a/changelog/fix_bug_unique_validation_without_index.md +++ /dev/null @@ -1 +0,0 @@ -* [#1130](https://github.com/rubocop/rubocop-rails/issues/1130): Fix crash for `Rails/UniqueValidationWithoutIndex` with bare validate. ([@jamiemccarthy][]) diff --git a/changelog/fix_false_positive_for_rails_redundant_active_record_dll_method.md b/changelog/fix_false_positive_for_rails_redundant_active_record_dll_method.md deleted file mode 100644 index 1a4d0c0cee..0000000000 --- a/changelog/fix_false_positive_for_rails_redundant_active_record_dll_method.md +++ /dev/null @@ -1 +0,0 @@ -* [#1124](https://github.com/rubocop/rubocop-rails/issues/1124): Fix false positives for `Rails/RedundantActiveRecordAllMethod` when receiver is not an Active Record model. ([@koic][])