Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support some Rails 7.1's new querying methods for Rails/RedundantActiveRecordAllMethod #1157

Conversation

koic
Copy link
Member

@koic koic commented Oct 14, 2023

Follow up rails/rails#44446, rails/rails#37944, rails/rails#46503, and rails/rails#47010.

This PR supports some Rails 7.1's new querying methods for Rails/RedundantActiveRecordAllMethod.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…iveRecordAllMethod`

Follow up rails/rails#44446, rails/rails#37944,
rails/rails#46503, and rails/rails#47010.

This PR supports some Rails 7.1's new querying methods for `Rails/RedundantActiveRecordAllMethod`.
@koic koic force-pushed the support_rails_7_1_methods_for_redundant_active_record_all_method branch from 1f5df37 to fbca0c4 Compare October 14, 2023 10:15
@koic koic merged commit 0b5019d into rubocop:master Oct 15, 2023
4 checks passed
@koic koic deleted the support_rails_7_1_methods_for_redundant_active_record_all_method branch October 15, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant