Mark Rails/TimeZone as unsafe auto-correction from unsafe
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to rubocop#575 (comment) This PR marks `Rails/TimeZone` as unsafe auto-correction from unsafe.
9 tasks
pirj
reviewed
Oct 12, 2021
| @@ -789,9 +789,9 @@ Rails/TimeZone: | |||
| StyleGuide: 'https://rails.rubystyle.guide#time' | |||
| Reference: 'http://danilenko.org/2012/7/6/rails_timezones' | |||
| Enabled: true | |||
There was a problem hiding this comment.
On an afterthought, we are effectively enabling the cop that was otherwise disabled for those running rubocop with --safe option. But I believe it is fine, since the default is to run all cops (as far as I understand).
There was a problem hiding this comment.
Yeah, this would be an acceptable change :-)
koic
deleted the
change_mark_rails_time_zone_as_unsafe_auto_correction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #575 (comment)
This PR marks
Rails/TimeZoneas unsafe auto-correction from unsafe.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.