Deprecate IgnoredMethods option
#750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rubocop/rubocop#10831 is required to resolve the build errors. |
koic
force-pushed
the
deprecate_ignore_methods_parameter
branch
from
289c0ab
to
9c00a7c
Compare
Follow up rubocop/rubocop#10829. This PR deprecates `IgnoredMethods` option in integrate to `AllowedMethods` and `AllowedPatterns` option. It requires RuboCop 1.33.0 or higher.
koic
force-pushed
the
deprecate_ignore_methods_parameter
branch
from
9c00a7c
to
ab3e176
Compare
|
@koic When is a release expected with these changes? |
|
Scheduled for the second half of this week. Please wait for a little while. |
Good. Thank you! |
|
@anton-co RuboCop Rails 2.16 has been released. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop#10829.
This PR deprecates
IgnoredMethodsoption in integrate toAllowedMethodsandAllowedPatternsoption.It requires RuboCop 1.33.0 or higher.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.