Merge pull request #791 from pirj/fix-described_class-cbase-edge-case

Fix a case for DescribedClass cop
rubocop · Jul 26, 2019 · 6420b04 · 6420b04
2 parents b1d531c + 8bbf5f0
commit 6420b04
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+* Fix `RSpec/DescribedClass`'s error when a local variable is part of the namespace. ([@pirj][])
+
 ## 1.34.0 (2019-07-23)
 
 * Remove `AggregateFailuresByDefault` config option of `RSpec/MultipleExpectations`. ([@pirj][])

diff --git a/lib/rubocop/cop/rspec/described_class.rb b/lib/rubocop/cop/rspec/described_class.rb
@@ -166,10 +166,10 @@ def const_name(node)
           # rubocop:enable InternalAffairs/NodeDestructuring
           if !namespace
             [name]
-          elsif namespace.cbase_type?
-            [nil, name]
-          else
+          elsif namespace.const_type?
             [*const_name(namespace), name]
+          elsif namespace.lvar_type? || namespace.cbase_type?
+            [nil, name]
           end
         end
 

diff --git a/spec/rubocop/cop/rspec/described_class_spec.rb b/spec/rubocop/cop/rspec/described_class_spec.rb
@@ -255,6 +255,18 @@ module D
         end
       RUBY
     end
+
+    it 'ignores if a local variable is part of the namespace' do
+      expect_no_offenses(<<-RUBY)
+        describe Broken do
+          [Foo, Bar].each do |klass|
+            describe klass::Baz.name do
+              it { }
+            end
+          end
+        end
+      RUBY
+    end
   end
 
   context 'when EnforcedStyle is :explicit' do