Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cop idea: disallow successive Array#push #12053

Open
ydakuka opened this issue Jul 17, 2023 · 1 comment
Open

Cop idea: disallow successive Array#push #12053

ydakuka opened this issue Jul 17, 2023 · 1 comment

Comments

@ydakuka
Copy link

ydakuka commented Jul 17, 2023

Actual behavior

I have the following code:

arr = []

arr.push(0)
arr.push(1)
arr.push(2)

# or

arr.push(0).push(1).push(2)

I run rubocop and don't get any offences:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop file.rb 
Inspecting 1 file
.

1 file inspected, no offenses detected

Expected behavior

I expected to receive the code:

arr = []

arr.push(0, 1, 2)

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.54.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.22.0
  - rubocop-thread_safety 0.5.1
@amomchilov
Copy link
Contributor

Even further, it'd be cool if another cop could take that output, and just simplify down to a literal:

-arr = []
+arr = [0, 1, 2]

-arr.push(0, 1, 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants